Skip to content

Revert "Split GroovyScript for agent and controller"#139

Closed
basil wants to merge 1 commit intojenkinsci:mainfrom
basil:revert
Closed

Revert "Split GroovyScript for agent and controller"#139
basil wants to merge 1 commit intojenkinsci:mainfrom
basil:revert

Conversation

@basil
Copy link
Member

@basil basil commented Jan 8, 2025

Revert #67, as this causes JENKINS-75019.

Testing done

Reproduced the problem as described in the Jira ticket and could no longer reproduce after this PR.

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

@basil basil added the bug label Jan 8, 2025
@basil basil requested a review from mtughan January 8, 2025 22:01
@ccjette-logmein
Copy link

@mtughan any hope this gets merged at some point ?

@mtughan
Copy link
Contributor

mtughan commented Jan 22, 2025

@basil, I'd really prefer not to revert this commit, as it's a security improvement (and pseudo-fix). I'm testing #141 now which should fix this while keeping the split between GroovyScript and ControllerGroovyScript.

@mtughan
Copy link
Contributor

mtughan commented Jan 22, 2025

Superseded by #141.

@mtughan mtughan closed this Jan 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants